Fix numato csr headers #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litex commit 8be5824e258b84df240d34636aaa539124b92c65 simplified the handling of csr regions and constants.
get_csr_header parameter with_shadow_base removed/deprecated in litex 2a8d8c8f. New default behavior matches the desired behavior in these targets.
|
@rohitk-singh do you still have access to boards to test? |
|
@mithro, Not with me here. But I can ask someone in the team at Numato to test this PR. From the looks, it should work though. |
|
Thanks @dkozel, @rohitk-singh, the PR was fine yes and i merged it. I also fixed the gateware/software builld directory with 7184032, it should now be fine. |
|
Great! Thanks @enjoy-digital! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit enjoy-digital/litex@8be5824 simplified the handling of csr regions and constants. These target files need to be updated to the new API.
They also still use the
with_shadow_baseparameter toget_csr_headerwhich was removed/deprecated in enjoy-digital/litex@a4ef9b2. I'm nearly positive that the new default behavior matches the previous behavior that the Numato targets were using.Longer discussion in #25