Gracefully handle SETUP packets whose wLength > 255. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't an exactly elegant solution, but since this device isn't responding to SETUP xfers with > 255 bytes anyway, I think saturating
wLengthto 255 is a reasonable solution.The old behavior was to send back
wLength % 256bytes. At least for this device, Windows will deliberately send a SETUP packet w/ length > 255- 265 in my case. The device responds with 9 bytes only, which is265 % 256. This is legal per USB, but the Windows driver interprets this as a malfunctioning device.By forcing
wLengthto 255, we still don't send 255 bytes back, but we at least send all the data back we mean to send.