You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Executing wishbone-tool with --server gdb without a crossover uart present results in an error. The following code snippet from config.rs seems to be missing the if-statement for ServerKind::Terminal or whatever it is called:
if server_kind.contains(&ServerKind::GDB){// You asked for --server gdb but no vexriscv jtag interfaces is found in the csr.csv file it should complain.if !register_mapping.contains_key("vexriscv_debug"){returnErr(ConfigError::InvalidConfig("GDB specified but no vexriscv address present in csv file".to_owned(),));}// You asked for --server terminal but no uart is found in the csr.csv file it should complain.if !(register_mapping.contains_key("uart_xover_rxtx")
&& register_mapping.contains_key("uart_xover_rxempty")
&& register_mapping.contains_key("uart_xover_ev_pending")){returnErr(ConfigError::InvalidConfig("Terminal specified, but no xover uart addresses present in csv file".to_owned(),));}}
The text was updated successfully, but these errors were encountered:
Previously, we would only validate the `uart_xover` keys were present if
the user specified a GDB server. This could result in a situation where
the user provided a csr-csv without a uart, but still wanted to run a
terminal.
In this case, `wishbone-tool` would fall back on its default, hardcoded
values of 0xe0001800, which is incorrect.
With this patch, specifying `-s terminal --csr-csv [file.csv]` when the
csv file has no `uart_xover` registers will now throw an error.
Furthermore, with this patch, the `-s gdb` option required a uart, which
would prevent a user from opening a gdb server on a device without a
uart.
This fixes#26.
Signed-off-by: Sean Cross <sean@xobs.io>
Executing
wishbone-tool
with--server gdb
without a crossover uart present results in an error. The following code snippet fromconfig.rs
seems to be missing the if-statement for ServerKind::Terminal or whatever it is called:The text was updated successfully, but these errors were encountered: