Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(probes): Make probe retry optional in crds to support value 0 (retries) AND rename defaultAppHealthCheck #424

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Chore(probes): Make probe retry optional in crds to support value 0 (retries) AND rename defaultAppHealthCheck #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a33ecd1
Chore(probes): Make probe retry optional in crds to support value 0 (…
uditgaurav Sep 30, 2022
aadbedd
defaultAppHealthCheck to defaultHealthCheck
uditgaurav Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/litmuschaos/v1alpha1/chaosengine_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ type ChaosEngineSpec struct {
Appinfo ApplicationParams `json:"appinfo,omitempty"`
//AnnotationCheck defines whether annotation check is allowed or not. It can be true or false
AnnotationCheck string `json:"annotationCheck,omitempty"`
//DefaultAppHealthCheck defines whether default health checks should be executed or not. It can be true or false
//DefaultHealthCheck defines whether default health checks should be executed or not. It can be true or false
// default value is true
DefaultAppHealthCheck string `json:"defaultAppHealthCheck,omitempty"`
DefaultHealthCheck string `json:"defaultHealthCheck,omitempty"`
//ChaosServiceAccount is the SvcAcc specified for chaos runner pods
ChaosServiceAccount string `json:"chaosServiceAccount"`
//Components contains the image, imagePullPolicy, arguments, and commands of runner
Expand Down
3 changes: 1 addition & 2 deletions deploy/chaos_crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
annotationCheck:
type: string
pattern: ^(true|false)$
defaultAppHealthCheck:
defaultHealthCheck:
type: string
pattern: ^(true|false)$
appinfo:
Expand Down Expand Up @@ -2013,7 +2013,6 @@ spec:
required:
- probeTimeout
- interval
- retry
properties:
probeTimeout:
type: integer
Expand Down
3 changes: 1 addition & 2 deletions deploy/crds/chaosengine_crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
annotationCheck:
type: string
pattern: ^(true|false)$
defaultAppHealthCheck:
defaultHealthCheck:
type: string
pattern: ^(true|false)$
appinfo:
Expand Down Expand Up @@ -2012,7 +2012,6 @@ spec:
required:
- probeTimeout
- interval
- retry
properties:
probeTimeout:
type: integer
Expand Down