-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(container-status): checking only target container status #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubhamchaudhary <shubham@chaosnative.com>
ispeakc0de
force-pushed
the
completed-container
branch
from
March 3, 2021 10:27
f5e1a31
to
ee48df5
Compare
Do you feel that even those experiments not traditionally needing container targets should be equipped with this check. Lets say, I have appinfo specified for a node chaos experiment and wish to validate running status of specific containers in that app described ? |
Signed-off-by: shubhamchaudhary <shubham@chaosnative.com>
ksatchit
approved these changes
Mar 14, 2021
uditgaurav
approved these changes
Mar 15, 2021
ispeakc0de
added a commit
to ispeakc0de/litmus-go
that referenced
this pull request
Mar 15, 2021
…schaos#303) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com>
ksatchit
pushed a commit
that referenced
this pull request
Mar 15, 2021
* chore(aut-check): skip autStatus check if appinfo not provided (#304) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * chore(n/w-chaos): Handling the unknown hosts (#302) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> * chore(signal): Adding signal for the crio/containerd runtime (#306) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * chore(disk-fill): Addding option to specify ephemeral storage(Mibi) explictly via env (#313) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * refactor(kafka-broker-pod-failure): Refactor the kafka broker pod failure (#309) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * Remove init container for changing permission of the container runtime socket (#315) * Removed init container from container-kill and network-chaos experiments Signed-off-by: Radu Domnu <rdomnu@redhat.com> * Running crictl/docker commands with sudo Signed-off-by: Radu Domnu <rdomnu@redhat.com> * Removed init container for network experiments Signed-off-by: Radu Domnu <rdomnu@redhat.com> * chore(k8sProbe): Updating the k8s probe schema (#308) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * api response time updated for http probe (#307) Signed-off-by: oumkale <oum.kale@mayadata.io> * chore(container-status): checking only target container status (#303) Signed-off-by: shubhamchaudhary <shubham@chaosnative.com> * enhance(aws-ec2): Add support for terminating node of a cluster with self-managed nodegroup (#298) * enhanc(aws-ec2): Add support for terminating node of a cluster with self-managed nodegroup Signed-off-by: udit <udit@chaosnative.com> Co-authored-by: Radu Domnu <39598837+radudd@users.noreply.github.com> Co-authored-by: OUM NIVRATHI KALE <oum.kale@mayadata.io> Co-authored-by: Udit Gaurav <35391335+uditgaurav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubhamchaudhary shubham@chaosnative.com