refactor(go-experiments): separate the types.go file for each experiment #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io>
ksatchit
reviewed
Jul 2, 2020
ksatchit
reviewed
Jul 2, 2020
Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io>
ksatchit
approved these changes
Jul 3, 2020
|
Good one @ispeakc0de ! |
uditgaurav
approved these changes
Jul 3, 2020
ksatchit
pushed a commit
that referenced
this pull request
Jul 6, 2020
* refactor(experiments): Refactor litmus go experiments (#29) Signed-off-by: Udit Gaurav <uditgaurav@gmail.com> * feat(experiments): Add pod memory hog experiment (#31) Signed-off-by: Udit Gaurav <uditgaurav@gmail.com> * refactor(go-experiments): separate the types.go file for each experiment (#34) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> * update(contribution-guide): updating contribution guide according to new schema changes (#35) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> * chore(experiment): Add pod network duplication experiment in generic experiments of LitmusChaos (#27) * chore(experiment): Add pod network duplication experiment in generic experiments of LitmusChaos Signed-off-by: Udit Gaurav <uditgaurav@gmail.com> * bug(fix): Add for summary event and getting target container name (#37) Signed-off-by: Udit Gaurav <uditgaurav@gmail.com> * bug(fix): Remove extra index from the list in pod duplication experiment (#38) Signed-off-by: Udit Gaurav <uditgaurav@gmail.com> Co-authored-by: Shubham Chaudhary <shubham.chaudhary@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubhamchaudhary shubham.chaudhary@mayadata.io