Chore(Enhancement): Changed Disk Fill experiment to not require CONTAINER_PATH
#605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaakash
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
neelanjan00
previously approved these changes
Nov 18, 2022
|
CI is failing, can you check? |
avaakash
force-pushed
the
disk-fill-helper
branch
2 times, most recently
from
fdd7372
to
137d73e
Compare
Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io>
avaakash
force-pushed
the
disk-fill-helper
branch
from
ea36101
to
4802d58
Compare
ispeakc0de
approved these changes
Nov 22, 2022
neelanjan00
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akash Shrivastava akash.shrivastava@harness.io
What this PR does / why we need it:
This PR makes the changes in the disk-fill experiment to remove the need to provide
CONTAINER_PATH.Previous implementation was to mount the provided path to the helper pod and use
ddNew implementation is to use the namespace mount with
ddWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag