Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(probe): Adding the root cause into probe description #628

Merged
merged 1 commit into from Jan 9, 2023

Conversation

ispeakc0de
Copy link
Member

@ispeakc0de ispeakc0de commented Dec 25, 2022

Signed-off-by: Shubham Chaudhary shubham.chaudhary@harness.io

What this PR does / why we need it:

Sample probe descriptions

HTTP Probe

- Probe responded with a invalid output. Actual value: 200 is not greater than Expected value: 400

- The URL https://litmuschaos.io did respond with correct status code. Actual and Expected status codes are 200 and 200 respectively

- Get "https://litmuschaos.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Cmd Probe

- Probe responded with a valid output. Actual and Expected values are ‘shubham’ and ‘shubham’ respectively

- Probe responded with a invalid output. Actual value: shubham doesn't matched with any of the Expected values: [hello world]

 - Either probe is not executed or not evaluated

K8s Probe

-  Probe is successfully performed the 'absent' operation on kubernetes resource

- no resource found with provided {labelSelectors: app=nginx, fieldSelectors: “”} selectors

- resource with provided {labelSelectors: app=nginx, fieldSelectors: “”} selectors should not exists, found 1 resource with matching selectors

PromProbe:

- Probe responded with a valid prometheus metrics value. Actual and Expected status values are 19565 and 100 respectively

- Probe responded with a invalid output. Actual value: 19823 is not lesser than Expected value: 100

- unable to run command, error: error querying prometheus: Post "http://35.184.156.158:31090/api/v1/query": context deadline exceeded

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

@neelanjan00
Copy link
Member

CI pipelines are failing; can you PTAL?

pkg/probe/comparator/float.go Outdated Show resolved Hide resolved
pkg/probe/comparator/float.go Outdated Show resolved Hide resolved
pkg/probe/promProbe.go Outdated Show resolved Hide resolved
@arkajyotiMukherjee
Copy link

arkajyotiMukherjee commented Dec 29, 2022

Looks good. Thanks @ispeakc0de

Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
@ispeakc0de ispeakc0de merged commit 3622f50 into litmuschaos:master Jan 9, 2023
@ksatchit
Copy link
Member

ksatchit commented Jan 9, 2023

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants