Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(unit): Adding units to the duration fields #650

Merged
merged 1 commit into from Apr 18, 2023

Conversation

ispeakc0de
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

pkg/types/types.go Outdated Show resolved Hide resolved
@ispeakc0de ispeakc0de force-pushed the duration-units branch 2 times, most recently from 3c8a020 to 98edb6e Compare April 18, 2023 07:27
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
@ispeakc0de ispeakc0de merged commit d3b760d into litmuschaos:master Apr 18, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants