-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593
(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593
Conversation
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>
Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>
Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>
Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>
…uirement Beta 2 mercedes feature requirement
…state management fixes. Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>
Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>
styling fixes for card background in dashboard graphs
…on fixes. Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
changes made.
@whitetiger1399 @Saranya-jena @arkajyotiMukherjee @SarthakJain26 PTAL again, changes have been made. |
@rajdas98 PTAL we need these changes as they are a blocker. cc: @ajeshbaby |
export const ACTIVE: string = 'Active'; | ||
export const MINIMUM_TOLERANCE_LIMIT: number = 4; | ||
export const DEFAULT_TOLERANCE_LIMIT: number = 14; | ||
export const INVALID_RESILIENCE_SCORE_STRING: string = 'NaN%'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NaN%
doesn't makes sense. it should be either 'NaN' or '--'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are appending percentage to the NaN string so we have to check this. we cannot use -- for the checking as its a valid score when workflow is running (for the chaos metric on graph), this is a check for invalid or missing resilience score. @whitetiger1399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or NA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whitetiger1399 changes made PTAL
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
@@ -0,0 +1,9 @@ | |||
import { createStyles, TableCell, withStyles } from '@material-ui/core'; | |||
|
|||
export const StyledTableCell = withStyles((theme) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the file name to StyledTableCell
marginTop: theme.spacing(5), | ||
marginLeft: theme.spacing(6), | ||
marginBottom: theme.spacing(8), | ||
marginTop: theme.spacing(-1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove the negative margin @vanshBhatia-A4k9 will fix it along with the other pages in his PR
}, | ||
|
||
refreshText: { | ||
marginTop: theme.spacing(-2.85), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you attach a screenshot of the component you are describing?
@arkajyotiMukherjee i have attached the screenshot already above PTAL (the refresh rate MUI select) |
Signed-off-by: ishangupta-ds <ishan@chaosnative.com>
/merge |
Proposed changes:
Types of changes:
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist:
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Special notes for your reviewer:
Analytics v2 implementation PR #1 for dashboard's monitoring page with feature updates and bug fixes for v1.
Screenshots:
Heap size usage reduction: