(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593

ishangupta-ds · 2021-03-24T05:19:54Z

Proposed changes:

Graph pop out mode
State-less Prometheus queries for chaos events
MongoDB resync updates removed
Optimization of analytics code for monitoring
Reducing heap-size usage
Time range/refresh rate selection
Chaos metrics on graphs with selection module.

Types of changes:

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes

Special notes for your reviewer:

Analytics v2 implementation PR #1 for dashboard's monitoring page with feature updates and bug fixes for v1.

Screenshots:

Heap size usage reduction:

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

…uirement Beta 2 mercedes feature requirement

…state management fixes. Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

styling fixes for card background in dashboard graphs

…on fixes. Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

changes made.

ishangupta-ds · 2021-04-06T08:51:37Z

@whitetiger1399 @Saranya-jena @arkajyotiMukherjee @SarthakJain26 PTAL again, changes have been made.

ishangupta-ds · 2021-04-06T08:52:35Z

@rajdas98 PTAL we need these changes as they are a blocker. cc: @ajeshbaby

whitetiger1399 · 2021-04-06T09:37:14Z

litmus-portal/frontend/src/pages/MonitoringDashboardPage/constants.ts

+export const ACTIVE: string = 'Active';
+export const MINIMUM_TOLERANCE_LIMIT: number = 4;
+export const DEFAULT_TOLERANCE_LIMIT: number = 14;
+export const INVALID_RESILIENCE_SCORE_STRING: string = 'NaN%';


NaN% doesn't makes sense. it should be either 'NaN' or '--'

we are appending percentage to the NaN string so we have to check this. we cannot use -- for the checking as its a valid score when workflow is running (for the chaos metric on graph), this is a check for invalid or missing resilience score. @whitetiger1399

@whitetiger1399 changes made PTAL

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

…requests

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

arkajyotiMukherjee · 2021-04-06T10:50:27Z

litmus-portal/frontend/src/components/StyledComponents/index.tsx

@@ -0,0 +1,9 @@
+import { createStyles, TableCell, withStyles } from '@material-ui/core';
+
+export const StyledTableCell = withStyles((theme) =>


please change the file name to StyledTableCell

arkajyotiMukherjee · 2021-04-06T10:56:24Z

litmus-portal/frontend/src/pages/MonitoringDashboardPage/styles.ts

-    marginTop: theme.spacing(5),
-    marginLeft: theme.spacing(6),
-    marginBottom: theme.spacing(8),
+    marginTop: theme.spacing(-1),


you can remove the negative margin @vanshBhatia-A4k9 will fix it along with the other pages in his PR

arkajyotiMukherjee · 2021-04-06T11:00:08Z

litmus-portal/frontend/src/pages/MonitoringDashboardPage/styles.ts

+  },
+
+  refreshText: {
+    marginTop: theme.spacing(-2.85),


can you attach a screenshot of the component you are describing?

ishangupta-ds · 2021-04-06T11:23:16Z

@arkajyotiMukherjee i have attached the screenshot already above PTAL (the refresh rate MUI select)

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

…requests

ishangupta-ds · 2021-04-06T13:24:37Z

/merge

ishangupta-ds added 5 commits March 19, 2021 18:34

Added clean up feature for disabled workflow events.

2c5af9c

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

temp-no-push

396c034

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

optimizations and state-less chaos events

209ffa8

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Resolved conflicts and updated branch to master

737ba48

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Updating prometheus query sync logic

4b549b6

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

ishangupta-ds added WIP state/dev-in-progress DO NOT MERGE area/litmus-portal labels Mar 24, 2021

ishangupta-ds added this to the 2.0-Beta-2 milestone Mar 24, 2021

ishangupta-ds assigned whitetiger1399 and ishangupta-ds Mar 24, 2021

ishangupta-ds marked this pull request as draft March 24, 2021 05:31

Ritik Srivastava and others added 16 commits March 25, 2021 12:47

expand button working

d982cc9

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

styling for grids

6e8cd67

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

translations added for tooltip

0e4a1f5

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

config reset

16083d9

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

Merge pull request #6 from whitetiger1399/beta-2-mercedes-feature-req…

85dd19c

…uirement Beta 2 mercedes feature requirement

Adding refresh rate selector and basic time range selector with some …

ce9f83c

…state management fixes. Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Resolved merge conflicts.

5da7499

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

minor fix

ec0bdd0

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

styling fixes for card background in dashboard graphs

741ad60

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

reset config

babf4e3

Signed-off-by: Ritik Srivastava <ritik.srivastava@mayadata.io>

Merge pull request #8 from whitetiger1399/mercedes-feature-requirement-2

aabaaa8

styling fixes for card background in dashboard graphs

Adding initial event mapping with refresh rate and time range selecti…

7b16882

…on fixes. Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Resolved merge conflicts.

dcd77ae

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

minor fix

18b3747

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

added filtering for chaos metrics.

67597f6

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

minor fixes

e071d7c

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

ishangupta-ds requested review from SarthakJain26, Saranya-jena, arkajyotiMukherjee and whitetiger1399 April 6, 2021 08:49

SarthakJain26 approved these changes Apr 6, 2021

View reviewed changes

whitetiger1399 reviewed Apr 6, 2021

View reviewed changes

ishangupta-ds added 2 commits April 6, 2021 15:45

minor NaN% fix.

8955e17

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

Merge remote-tracking branch 'upstream/master' into mercedes-feature-…

32315b0

…requests

ishangupta-ds requested a review from whitetiger1399 April 6, 2021 10:20

removed an unused variable.

831d0b4

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

arkajyotiMukherjee requested changes Apr 6, 2021

View reviewed changes

fix after review.

2d626e1

Signed-off-by: ishangupta-ds <ishan@chaosnative.com>

arkajyotiMukherjee approved these changes Apr 6, 2021

View reviewed changes

codesniffy bot added the READY TO MERGE label Apr 6, 2021

Merge remote-tracking branch 'upstream/master' into mercedes-feature-…

d7aa85c

…requests

whitetiger1399 approved these changes Apr 6, 2021

View reviewed changes

whitetiger1399 removed the DO NOT MERGE label Apr 6, 2021

ishangupta-ds added state/review-complete and removed PR: Changes Requested state/review-in-progress labels Apr 6, 2021

github-actions bot added the merge label Apr 6, 2021

probot-auto-merge bot merged commit d5173bf into litmuschaos:master Apr 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593

(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593

ishangupta-ds commented Mar 24, 2021 •

edited

Loading

ishangupta-ds commented Apr 6, 2021

ishangupta-ds commented Apr 6, 2021

whitetiger1399 Apr 6, 2021

ishangupta-ds Apr 6, 2021

whitetiger1399 Apr 6, 2021

ishangupta-ds Apr 6, 2021

arkajyotiMukherjee Apr 6, 2021

arkajyotiMukherjee Apr 6, 2021

arkajyotiMukherjee Apr 6, 2021

ishangupta-ds commented Apr 6, 2021

ishangupta-ds commented Apr 6, 2021

		@@ -0,0 +1,9 @@
		import { createStyles, TableCell, withStyles } from '@material-ui/core';

		export const StyledTableCell = withStyles((theme) =>

(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593

(litmus-portal): Graph pop out mode, state-less prometheus queries for chaos events, mongoDB resync updates removed, optimization of analytics code for monitoring, reducing heap-size usage, time range / refresh rate selection and chaos metrics on graphs with selection module. #2593

Conversation

ishangupta-ds commented Mar 24, 2021 • edited Loading

Proposed changes:

Types of changes:

Checklist:

Special notes for your reviewer:

Screenshots:

Heap size usage reduction:

ishangupta-ds commented Apr 6, 2021

ishangupta-ds commented Apr 6, 2021

whitetiger1399 Apr 6, 2021

Choose a reason for hiding this comment

ishangupta-ds Apr 6, 2021

Choose a reason for hiding this comment

whitetiger1399 Apr 6, 2021

Choose a reason for hiding this comment

ishangupta-ds Apr 6, 2021

Choose a reason for hiding this comment

arkajyotiMukherjee Apr 6, 2021

Choose a reason for hiding this comment

arkajyotiMukherjee Apr 6, 2021

Choose a reason for hiding this comment

arkajyotiMukherjee Apr 6, 2021

Choose a reason for hiding this comment

ishangupta-ds commented Apr 6, 2021

ishangupta-ds commented Apr 6, 2021

ishangupta-ds commented Mar 24, 2021 •

edited

Loading