Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(litmus-portal): Added parallel and serial sequencing of experiments for workflow creation #2734

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

amityt
Copy link
Contributor

@amityt amityt commented Apr 21, 2021

Signed-off-by: Amit Kumar Das amit@chaosnative.com

Proposed changes

This PR adds:

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

1. Parallel sequencing for Kube-Proxy-Chaos experiement (Pre-defined experiment)
Screenshot from 2021-04-21 20-00-15

2. Parallel sequencing with custom workflows
Screenshot from 2021-04-21 20-01-25

Signed-off-by: Amit Kumar Das <amit@chaosnative.com>
@codesniffy codesniffy bot added the size/L label Apr 21, 2021
@amityt amityt self-assigned this Apr 21, 2021
@@ -61,6 +61,7 @@ const useStyles = makeStyles((theme) => ({
// Modal
closeButton: {
borderColor: theme.palette.border.main,
marginTop: theme.spacing(-3.75),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create an issue also in litmus-ui for this negative margin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will try to remove this negative margin with some fix. Thanks @ishangupta-ds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's fine here, no need to deviate from the design but please create a issue or add link to this PR to exiting modal issue on litmus-ui

Copy link
Member

@ishangupta-ds ishangupta-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@S-ayanide S-ayanide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S-ayanide S-ayanide merged commit 575d96f into litmuschaos:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants