chore: Added UI changes for enable and disable cron feature #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Saranya-jena
requested review from
SahilKr24,
namkyu1999 and
arkajyotiMukherjee
Saranya-jena
approved these changes
Nov 10, 2023
arkajyotiMukherjee
requested changes
Nov 10, 2023
Comment on lines
73
to
77
| experimentData && experimentData?.experimentType === ExperimentType.CRON | ||
| ? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
| : true | ||
| ? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
| : (parsedManifest as CronWorkflow)?.spec?.suspend; |
There was a problem hiding this comment.
can we clean this up in a function with if statements instead of ternary
Comment on lines
53
to
59
| const isCronEnabled = | ||
| specificRunExists && specificRunData?.experimentType === ExperimentType.CRON | ||
| ? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
| : true | ||
| ? (parsedManifest as CronWorkflow)?.spec?.suspend !== undefined | ||
| : (parsedManifest as CronWorkflow)?.spec?.suspend; | ||
|
|
There was a problem hiding this comment.
isCronEnabled could be a func in of itself
Comment on lines
156
to
162
| const isCronEnabled = | ||
| experimentRunsWithExecutionData && experimentType === ExperimentType.CRON | ||
| ? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
| : true | ||
| ? (parsedManifest as CronWorkflow)?.spec?.suspend !== undefined | ||
| : (parsedManifest as CronWorkflow)?.spec?.suspend; | ||
|
|
namkyu1999
approved these changes
Nov 12, 2023
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
arkajyotiMukherjee
approved these changes
Nov 15, 2023
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
S-ayanide
approved these changes
Nov 15, 2023
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added frontend changes for enable and disable cron feature. This provides and option to toggle the cron schedule by enabling and disabling the experiments.
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: