-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added UI changes for enable and disable cron feature #4286
Conversation
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
experimentData && experimentData?.experimentType === ExperimentType.CRON | ||
? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
: true | ||
? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
: (parsedManifest as CronWorkflow)?.spec?.suspend; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we clean this up in a function with if statements instead of ternary
const isCronEnabled = | ||
specificRunExists && specificRunData?.experimentType === ExperimentType.CRON | ||
? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
: true | ||
? (parsedManifest as CronWorkflow)?.spec?.suspend !== undefined | ||
: (parsedManifest as CronWorkflow)?.spec?.suspend; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isCronEnabled could be a func in of itself
const isCronEnabled = | ||
experimentRunsWithExecutionData && experimentType === ExperimentType.CRON | ||
? (parsedManifest as CronWorkflow)?.spec?.suspend === undefined | ||
: true | ||
? (parsedManifest as CronWorkflow)?.spec?.suspend !== undefined | ||
: (parsedManifest as CronWorkflow)?.spec?.suspend; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Signed-off-by: Amit Kumar Das <amit.das@harness.io>
Proposed changes
Added frontend changes for enable and disable cron feature. This provides and option to toggle the cron schedule by enabling and disabling the experiments.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: