-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Login with SSO
button when Dex is enabled
#4538
Conversation
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
b77f22c
to
64982a4
Compare
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
64982a4
to
3c87687
Compare
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
66044d5
to
3cd2b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BE changed looks good to me 🚀
@DarthBenro008 Can you also review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@Saranya-jena, I'm just checking in. Would it be possible to have this change in the next release? |
Yes sure @smitthakkar96. We will try to take this PR in the upcoming release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Fixes #4236
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: