Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added username and password validation for various screen #4650

Merged
merged 3 commits into from
May 18, 2024

Conversation

SahilKr24
Copy link
Member

@SahilKr24 SahilKr24 commented May 16, 2024

Proposed changes

This PR adds field validation support. This validation includes

Username:

# Must start with a letter
# Allow letters, digits, underscores, and hyphens
# Ensure the length of the username is between 3 and 16 characters 
Password:

# At least one lowercase letter
# At least one uppercase letter
# At least one digit
# At least one special character @$!%*?_&
# Allowed characters: letters, digits, special characters @$!%*?_&
# Length between 8 to 16 characters

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Sahil <sahil.kumar@harness.io>
Signed-off-by: Sahil <sahil.kumar@harness.io>
Copy link
Member

@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, LGTM!

@Saranya-jena Saranya-jena merged commit ae21ffb into litmuschaos:master May 18, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants