Added strict validation for username and password in backend. #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aryan <aryan1bhokare@gmail.com>
SahilKr24
reviewed
May 23, 2024
Signed-off-by: aryan <aryan1bhokare@gmail.com>
SahilKr24
reviewed
May 23, 2024
SahilKr24
reviewed
May 23, 2024
aryan-bhokare
force-pushed
the
backend-validation-username-password
branch
from
bef75aa
to
edaa0cf
Compare
Signed-off-by: aryan <aryan1bhokare@gmail.com>
aryan-bhokare
force-pushed
the
backend-validation-username-password
branch
from
edaa0cf
to
3d2c6c1
Compare
Signed-off-by: aryan <aryan1bhokare@gmail.com>
Signed-off-by: aryan <aryan1bhokare@gmail.com>
aryan-bhokare
force-pushed
the
backend-validation-username-password
branch
from
2b85b38
to
2e5b970
Compare
SahilKr24
approved these changes
May 29, 2024
|
@aryan-bhokare, can you please add an ENV to enable/disable the strict password validation. This ENV (ENABLE_STRICT_PASSWORD_POLICY) will be true by default, i.e. strict password policy check will be implemented, but user can toggle that off based on the use case. |
| @@ -23,10 +23,15 @@ func ValidateStrictPassword(input string) error { | |||
| if len(input) < 8 { | |||
| return fmt.Errorf("password is less than 8 characters") | |||
| } | |||
|
|
|||
| if len(input) > 16 { | |||
There was a problem hiding this comment.
Upper limit check may not be required
There was a problem hiding this comment.
Can you explain why that would not be required @SarthakJain26 ?
Jonsy13
reviewed
Jun 19, 2024
Jonsy13
reviewed
Jun 19, 2024
hrishavjha
approved these changes
Jun 19, 2024
Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
Signed-off-by: aryan <aryan1bhokare@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added validation for username and password in backend.
Following #4650
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: