Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed k8s client go dependencies from graphql #4747

Merged
merged 17 commits into from
Jul 8, 2024

Conversation

Saranya-jena
Copy link
Contributor

@Saranya-jena Saranya-jena commented Jul 5, 2024

Proposed changes

Removed k8s client go dependencies from graphql server. This enables us to restrict the scope of what graphql server can do regarding interactions with hosts and other system backend services(i.e. k8s). As part of the change, the host IP is now extracted from the HTTP header thus removing the requirement if using client-go to find out the endpoint.

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
@Saranya-jena Saranya-jena requested a review from Jonsy13 July 5, 2024 14:05
@Saranya-jena Saranya-jena self-assigned this Jul 5, 2024
Copy link
Contributor

@shovanmaity shovanmaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
data:
DB_SERVER: mongodb://my-release-mongodb-0.my-release-mongodb-headless:27017,my-release-mongodb-1.my-release-mongodb-headless:27017,my-release-mongodb-2.my-release-mongodb-headless:27017/admin
VERSION: "ci"
SKIP_SSL_VERIFY: "false"
# Configurations if you are using dex for OAuth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add Dex config back in both manifests

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
@Saranya-jena Saranya-jena merged commit a00691f into litmuschaos:master Jul 8, 2024
19 checks passed
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* removed k8s client-go dependencies

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Update push.yml

* removed k8s client-go dependencies

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* reverted changes for push pipeline

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated go mod

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated mocks

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifests

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifest

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifest

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

---------

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* removed k8s client-go dependencies

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Update push.yml

* removed k8s client-go dependencies

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* reverted changes for push pipeline

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated go mod

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated mocks

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifests

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifest

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifest

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

---------

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
* removed k8s client-go dependencies

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Update push.yml

* removed k8s client-go dependencies

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* removed token issues

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* reverted changes for push pipeline

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated go mod

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated mocks

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifests

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifest

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated manifest

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

---------

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants