Skip to content
This repository has been archived by the owner on Sep 30, 2019. It is now read-only.

Unable to find logical ref resource for #112

Closed
bboure opened this issue Apr 24, 2019 · 3 comments
Closed

Unable to find logical ref resource for #112

bboure opened this issue Apr 24, 2019 · 3 comments

Comments

@bboure
Copy link
Contributor

bboure commented Apr 24, 2019

@lightsofapollo

Since #65 was merged I get this kind of error all over the place.

Error: Unable to find logical ref resource for : AWS::Cognito::UserPool (custom.appSync.userPoolConfig.userPoolId.Ref)

The reason is that the implementation only supports DynamoDb resolution for now and throws an exception on any other resource.

This is a breaking change. Before this, userPoolId being a reference did not cause any problem since the emulator simply ignores/mocks authentication.

This error also occurs in any other resource referencing another, even if not even related to AppSync at all.

I suggest we change this line to fallback to the previous behaviour and simply return value untouched/unresolved, instead of throwing an exception.

@pianomansam
Copy link
Contributor

pianomansam commented Apr 24, 2019 via email

@lightsofapollo
Copy link
Contributor

@pianomansam This should be fixed in 0.12 onward. Can you confirm this works for you?

@pianomansam
Copy link
Contributor

@lightsofapollo this appears to be fixed on 0.12

@cbaron cbaron closed this as completed May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants