This repository has been archived by the owner on Sep 30, 2019. It is now read-only.
Fix cfRef Resolver #113
Merged
Fix cfRef Resolver #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed that using this fix on the |
|
I don't have much context on this issue, but LGTM. |
|
I had more issue because of the other Exceptions |
|
Nice thank you for the fix |
|
@bboure Can you update the test checking for this and potentially add a test with the case that effected you? I want to make sure we do not regress this behavior. |
lightsofapollo
suggested changes
Apr 26, 2019
|
@lightsofapollo I added test based on my use case. |
|
@bboure Looks good to me! Ship it! |
lightsofapollo
approved these changes
Apr 29, 2019
|
merged and version bumped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lightsofapollo as discussed in #112
This fixes my issue