This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
Add XFRM support #298
Open
Add XFRM support #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messages for IPsec.
(the kernel allows up to 6). * Added a message GetDumpMessage to dump xfrm states with an address filter attribute. * Fix typo for IPSEC_PROTO_ANY constant, added constants for ESP encapsulation types. * Added default implementations for LifetimeConfig, SecurityCtx and UserTemplate.
interface to all of the messages/structs in netlink-packet-xfrm. Mimics most of the functionality provided by iproute2 xfrm policy/state/monitor which is primarily used for setting up IPsec tunnels.
wllenyj
reviewed
Oct 24, 2022
xfrmnetlink/Cargo.toml
Outdated
| futures = "0.3.11" | ||
| log = "0.4.8" | ||
| thiserror = "1" | ||
| netlink-packet-core = { path = "../netlink-packet-core" } |
There was a problem hiding this comment.
I feel that a version field is meeded.
There was a problem hiding this comment.
Yes, I missed that. I also removed two dependencies that weren't being used (I originally copied the Cargo.toml from rtnetlink).
|
Can you move this pr to https://github.com/rust-netlink? |
|
@wllenyj We have to create a repo first. @cathay4t I'm not sure how we use https://github.com/rust-netlink/new-crate-review, could you clarify its usecase? |
Removed unused dependencies on log and nix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some code to support the netlink xfrm API, primarily to support management of IPsec tunnels. Similar to the other protocols, I've split it up into netlink-packet-xfrm for message parse/emit, and xfrmnetlink for request/response handling. Feel free to add to your project if desired, or let me know if there's anything that should be changed to make it more suitable for inclusion. Thx.