-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to .scss and update font-awesome to v.3.2.1 #37
Conversation
+1 ! Can't believe I was just looking for this and you submitted the pull request 12 hours ago! |
Bump the version on the file
Move to own directory to avoid name collision with _bootstrap
Looking forward for this merge :) |
+1 |
+1 thanks @pduersteler for doing this |
+1 now using @pduersteler 's fork until this is accepted :) |
+1 |
1 similar comment
👍 |
You should change this to use font-url method as it doesn't properly use the asset pipeline |
Good point @kevindew , I have just made the changes for that and made a pull request... I'ts important to use the asset pipeline to cache correctly the font on the person's browser and avoid reloading, right?! Best, |
Use font asset pipeline
Remove gem_variables also from main file
Thanks @viniciusnz putting it through the font-url method sets the correct path for the assets (what's set in |
+1 👍 Please merge and publish a new gem version! |
Hsiao-Ting Yu seems offline, if you guys are like me you can just switch to https://github.com/bokmann/font-awesome-rails it's up-to-date |
The changes are also implemented in my fork, with some pull requests merged
|
+1 Please merge and push a new gem version, thanks! |
Looking forward to the merge. |
+1 |
I've also added a separate config file to fix the path because of the assets pipeline. This makes it easier to copy the original
_variables.scss
without breaking functionality.