Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to .scss and update font-awesome to v.3.2.1 #37

Closed
wants to merge 11 commits into from
Closed

Migrate to .scss and update font-awesome to v.3.2.1 #37

wants to merge 11 commits into from

Conversation

pduersteler
Copy link

I've also added a separate config file to fix the path because of the assets pipeline. This makes it easier to copy the original _variables.scss without breaking functionality.

@pduersteler pduersteler mentioned this pull request Jul 17, 2013
@viniciusnz
Copy link

+1 ! Can't believe I was just looking for this and you submitted the pull request 12 hours ago!

@randoum
Copy link

randoum commented Jul 19, 2013

Looking forward for this merge :)

@igajard1
Copy link

+1

@goosetav
Copy link

+1 thanks @pduersteler for doing this

@rpocklin
Copy link

+1 now using @pduersteler 's fork until this is accepted :)

@abrambailey
Copy link

+1

1 similar comment
@wyaeld
Copy link

wyaeld commented Jul 24, 2013

👍

@kevindew
Copy link

kevindew commented Aug 2, 2013

You should change this to use font-url method as it doesn't properly use the asset pipeline

@viniciusnz
Copy link

Good point @kevindew , I have just made the changes for that and made a pull request... I'ts important to use the asset pipeline to cache correctly the font on the person's browser and avoid reloading, right?! Best,

@kevindew
Copy link

kevindew commented Aug 3, 2013

Thanks @viniciusnz putting it through the font-url method sets the correct path for the assets (what's set in config.assets.prefix which might not necessarily be /assets) and in production mode it will add a cache busting url (e.g. url(/assets/fontawesome-webfont-009f6d1f667cc42c25e712ab3429cbc7.eot)
This means we probably don't need the font awesome version number (as I think that's intended as a cache buster) but don't think it hurts either.

@raskhadafi
Copy link

+1 👍

Please merge and publish a new gem version!
Thanks in advance

@randoum
Copy link

randoum commented Aug 14, 2013

Hsiao-Ting Yu seems offline, if you guys are like me you can just switch to https://github.com/bokmann/font-awesome-rails it's up-to-date

@pduersteler
Copy link
Author

The changes are also implemented in my fork, with some pull requests merged
from other users... ;)
Am 15.08.2013 01:30 schrieb "randoum" notifications@github.com:

Hsiao-Ting Yu seems offline, if you guys are like me you can just switch
to https://github.com/bokmann/font-awesome-rails it's up-to-date


Reply to this email directly or view it on GitHubhttps://github.com//pull/37#issuecomment-22675500
.

@pavlo
Copy link

pavlo commented Aug 17, 2013

+1

Please merge and push a new gem version, thanks!

@netwire88
Copy link

Looking forward to the merge.

@joshuap
Copy link

joshuap commented Oct 1, 2013

+1

thotmx pushed a commit to LogicalBricks/font-awesome-sass-rails that referenced this pull request Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.