Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel PR for BigDecimal syntax: volunteers wanted #18

Closed
littledan opened this issue Nov 13, 2019 · 4 comments · Fixed by babel/babel#11640
Closed

Babel PR for BigDecimal syntax: volunteers wanted #18

littledan opened this issue Nov 13, 2019 · 4 comments · Fixed by babel/babel#11640

Comments

@littledan
Copy link
Member

littledan commented Nov 13, 2019

BigDecimal adds the 123.456d syntax for BigDecimal literals. Probably there's no good Babel transform to implement BigDecimal, but it would be useful for tools to be able to parse and generate it. One place to start would be to create a PR for Babel providing the new syntax, in parsing and generation. It will not make sense to land this PR until BigDecimal is at Stage 1 at least. Volunteers wanted!

@rickbutton
Copy link
Member

very interested

@JLHwung
Copy link
Contributor

JLHwung commented May 29, 2020

Babel PR: babel/babel#11640

@Mitscherlich
Copy link

Mitscherlich commented Dec 22, 2021

I create a JSBD-style babel transformer based on this implement in this PR and inspired by babel-plugin-transform-bigint. Maybe check it out if interested. 😄

@sarahghp
Copy link
Contributor

sarahghp commented Jan 12, 2022

Hii @Mitscherlich. Thanks for working on this babel transformer. I recently took on this project as co-champion and have also started working on Babel transforms for the playground project. I'm not at the point where I am certain how to best combine our efforts, but I should have some thoughts soon.

There is also still some API unsteadyness, which may effect some feedback. For instance, I see that you have included **, but I think that will not end up being the case.

In the meantime, I am going to go ahead and close this issue for now so no one does work that might not be used and I will reopen when we have a slightly more stable API and I am better caught up.

Thank you again for this work; I look forward to collaborating more in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants