fix(ext/node): pass normalized watchFile handler to StatWatcher

Fixes denoland#22939
littledivy · Mar 15, 2024 · 7f0bfe2 · 7f0bfe2
1 parent dae162f
commit 7f0bfe2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/ext/node/polyfills/_fs/_fs_watch.ts b/ext/node/polyfills/_fs/_fs_watch.ts
@@ -211,7 +211,7 @@ export function watchFile(
     statWatchers.set(watchPath, stat);
   }
 
-  stat.addListener("change", listener!);
+  stat.addListener("change", handler);
   return stat;
 }
 

diff --git a/tests/unit_node/_fs/_fs_watch_test.ts b/tests/unit_node/_fs/_fs_watch_test.ts
@@ -1,6 +1,6 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
-import { watch } from "node:fs";
-import { assertEquals } from "@std/assert/mod.ts";
+import { Stats, unwatchFile, watch, watchFile } from "node:fs";
+import { assert, assertEquals } from "@std/assert/mod.ts";
 
 function wait(time: number) {
   return new Promise((resolve) => {
@@ -25,3 +25,16 @@ Deno.test({
     assertEquals(result.length >= 1, true);
   },
 });
+
+Deno.test({
+  name: "watching a file with options",
+  async fn() {
+    const file = Deno.makeTempFileSync();
+    const watcher = watchFile(
+      file,
+      () => {},
+    );
+    await wait(100);
+    unwatchFile(file);
+  },
+});