init disk instance before use #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under some compilers (e.g. MSVC) the variable may not be init to 0 which can lead to a crash at line 918
Tests passed ✓, Code: 16670 B (+0.0%), Stack: 1432 B (+0.0%), Structs: 788 B (+0.0%)
|
Tests passed ✓, Code: 16670 B (+0.0%), Stack: 1432 B (+0.0%), Structs: 788 B (+0.0%)
|
|
Hi @ThomasAUB, thanks for creating a PR. It's worth noting that uninitialized struct does go unused. It gets stored to an explicit stack, which is probably why MSVC is tripping over it, but it doesn't get accessed unless the highest bit in the tag is set, which only occurs when we assign contents to the struct. But we can go ahead an merge this to fix the warning. Though it looks like @mdahamshi made a PR earlier, so will go with that one: #855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under some compilers (e.g. MSVC) the variable may not be init to 0 which can lead to a crash at line 918