training coordinates fix #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
If more than one dataset has been passed for validation, the prediction callback automatic inference uses the first one, we warn the user about this behavior.
for more information, see https://pre-commit.ci
Valahaar
reviewed
Mar 30, 2022
| compute_main_extension=True, | ||
| ) | ||
| logger.info( | ||
| f"Main extension found: {train_coordinates.main_file_extension}" | ||
| ) | ||
| else: | ||
| train_coordinates.train_bundle = load_bundle( | ||
| coordinates_dict.get("train_dataset") | ||
| coordinates_dict.get("train_dataset"), |
There was a problem hiding this comment.
shouldn't this become dataset (instead of train_dataset) in the new version? should we address this now or later?
There was a problem hiding this comment.
Nope this is only the training coordinates file
There was a problem hiding this comment.
mmm I'd like to be consistent, is it possible or does it break something?
Valahaar
reviewed
Mar 30, 2022
| @@ -23,3 +25,22 @@ but you can [add custom formats](/docs/getting-started/customizing-things/custom | |||
| If your dataset is already formatted like this, great! Otherwise, this is the only bit where coding is required. | |||
| You can either convert it yourself (via a python or bash script, whatever you're comfortable with), or you can register | |||
| a [custom data reader](/docs/getting-started/customizing-things/custom-data-format/) to support your dataset format. | |||
|
|
|||
|
|
|||
| ## Datasets Organization | |||
There was a problem hiding this comment.
"organization" here does not translate from Italian :D I'd say Datasets Folder Structure
There was a problem hiding this comment.
Organizing? Because it does not have to be a folder.
There was a problem hiding this comment.
yup, Organizing Datasets sounds a lot better
added 2 commits
March 30, 2022 12:15
…to bug-fix/training-coordinates
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.