-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
before option not working anymore #151
Comments
@matlar83 can you try and see if https://github.com/liuggio/fastest/tree/input_args_parsing fix this? |
@DonCallisto, it does not fix it, according to my tests. Performed test:
Can you reproduce it? |
I confirm, -b/--before isn't working |
I was able to reproduce. If someone would like to help (with suggestions I gave before) is welcome to do so. |
Option --before is broken in the latest version (liuggio/fastest#151), and we use it when running PHPUnit testsuite in parallel.
@matlar83 @Brightside56 sorry for the long delay, I was quite busy. Could you give it a shot and let me know if it's ok for your projects? |
If no one will give a feedback, I'm gonna merge the PR within this week and release a new tagged version in order to let everyone use new code. |
Sorry @DonCallisto, I don't have time to test it :-( I hope I will have in the next weeks, but I'm not sure |
Don't worry. I've used your test cases as guidelines and it works like a charm, so I'm pretty sure we won't have surprise here. |
I've released v1.7.1 https://github.com/liuggio/fastest/releases/tag/v1.7.1 |
Gonna close it for the moment. |
With the last version (v1.7.0) the --before command option seems not to work anymore.
Steps to reproduce:
with version 1.6.1:
Status OK: before command is executed
with version 1.7.0:
Status KO: before command is not executed
Some other issues related to --before option, also in v.1.6.1:
The text was updated successfully, but these errors were encountered: