Added Symfony 5 support

[DonCallisto]

No description provided.

[DonCallisto]

Hello everybody.
It seems that Symfony 5 compatibility is (almost) here!
Sorry in advance for this delay, but I'm not having much time that can be allocated for OSS (unfortunately).
Before relase a new tagged version (1.7.0) I would like everyone has opened a PR, or just asked for SF5 support, to test new code in order to check if everyrhing is OK.
To test this, just require the commit through composer: "liuggio/fastest": "dev-master#8512f8e621f0a6340cd12946feb5d9569a59498a", and you'll obtain the fix.
Please, let me know if it works for you: the faster you'll acknowledge this, the faster I can make a new relase.

Thanks.

[matlar83]

Hi,
I can't figure out how to require the specific commit.
I just created a new Symfony5 project and then run composer require --dev "liuggio/fastest:dev-master#8512f8e621f0a6340cd12946feb5d9569a59498a" but I got the following error:

./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Restricting packages listed in "symfony/symfony" to "5.1.*"
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for liuggio/fastest dev-master#8512f8e621f0a6340cd12946feb5d9569a59498a -> satisfiable by liuggio/fastest[dev-master].
    - liuggio/fastest dev-master requires symfony/console ^3.4|^4.2 -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

It's the first time I try to require a not stable version of a package, so I probably make a mistake.
Do you have any hint?
Thank you

[DonCallisto]

@matlar83 umh, maybe you should also add this

"repositories": [
        {
          "type": "vcs",
          "url": "git@github.com:DonCallisto/fastest.git"
        },
]

in your composer.json? I'm not sure how to handle those situations (TBH, on my machine it works without this)

[matlar83]

I got it.
I have to add the repository as you suggested:

"repositories": [
        {
          "type": "vcs",
          "url": "git@github.com:DonCallisto/fastest.git"
        },
]

and then require the commit from the sf5 branch:
composer require --dev "liuggio/fastest:dev-sf5#8512f8e621f0a6340cd12946feb5d9569a59498a"

I will test it in my main project in a few minutes and come back to you.

[matlar83]

Tested this specific commit against my main project functional test suite (347 behat scenarios) with my project both on symfony 4.4.8 and 5.0.9 and worked like a charm! No problems at all.

Just one note:
why in this commit you add "phpunit/phpunit" as a dependency? It does not seems to be used in the code, maybe just in tests?
Could you consider moving it as a dev dependency?
I do not use phpunit in my projects so far and I had to downgrade other dependencies just to resolve requirements to an installable set of packages.

Thank you very much for your work, I really appreciate it

[DonCallisto]

Having phpunit as dep was a mistake due to a composer command, I guess. Of course phpunit should not be a dependency at all, as it was before this change. I'll get rid of this as soon as other will have tested and no regressions are introduced. If no one will try this, I plan to make a new release next week.

[DonCallisto]

v1.7.0 released https://github.com/liuggio/fastest/releases/tag/v1.7.0

[matlar83]

@DonCallisto, v1.7.0 seems to have problems with --before command option. See #151