Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.10.0 BUG on vite dev server start (works fine with v1.9.0) #47

Closed
pwoloszun opened this issue Sep 26, 2022 · 8 comments
Closed

v1.10.0 BUG on vite dev server start (works fine with v1.9.0) #47

pwoloszun opened this issue Sep 26, 2022 · 8 comments
Labels

Comments

@pwoloszun
Copy link

It works fine with v1.9.0, BUT v1.10.0 throws this error:

error when starting dev server:
Error: Dynamic require of "fs" is not supported
    at file:///home/my-user/my-project/node_modules/vite-plugin-mkcert/dist/mkcert.mjs:13:9

My env info:
npx envinfo --system --npmPackages vite,vite-plugin-mkcert --binaries

System:
    OS: Linux 5.15 Ubuntu 20.04.5 LTS (Focal Fossa)
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v16.16.0/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
  npmPackages:
    vite: ~3.1.3 => 3.1.3 
    vite-plugin-mkcert: 1.10.0 => 1.10.0 

vite.config.ts:

import { defineConfig } from 'vite';
import mkcert from 'vite-plugin-mkcert';

export default defineConfig({
  server: {
    https: true,
  },

  plugins: [mkcert()]
});
@arunmmanoharan
Copy link

I get a different error.

The "path" argument must be of type string or an instance of URL. Received undefined

image

@VincentLandais
Copy link

I am also facing this issue

Screenshot 2022-09-27 at 11 13 42

@chrisrowe
Copy link

Same, getting path error not fs though they seem interchangable.

@cafesao
Copy link

cafesao commented Sep 27, 2022

Same error here.

image

If you are facing this problem, for the time being the option is to get a replacement.

I recommend vite-plugin-basic-ssl

@moalamri
Copy link

moalamri commented Sep 28, 2022

Getting the same error, downgraded to v1.9.0 solved it

It seems like in the last update you switched from vite to esbuild which caused this problem, more info

@chrisrowe
Copy link

Thanks so much @liuweiGL

github-actions bot pushed a commit that referenced this issue Sep 28, 2022
## [1.10.1](v1.10.0...v1.10.1) (2022-09-28)

### Bug Fixes

* generated code include vite code ([e5adc6b](e5adc6b)), closes [#47](#47)
* vite version range incorrect ([1486c44](1486c44))
@liuweiGL
Copy link
Owner

🎉 This issue has been resolved in version 1.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@liuweiGL
Copy link
Owner

🤝

github-actions bot pushed a commit to skymoonya/rsbuild-plugin-mkcert that referenced this issue Mar 14, 2024
# 1.0.0 (2024-03-14)

### Bug Fixes

* additional path escaping issue [liuweiGL#80](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/80) ([liuweiGL#81](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/81)) ([a3bbe6c](a3bbe6c))
* fix access denied error caused by JAVA_HOME ([f4f7c18](f4f7c18)), closes [liuweiGL#15](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/15)
* fix built assets error ([12a2de4](12a2de4))
* fix import commonjs modules error ([d7bfaa0](d7bfaa0))
* fix npm package not includes built files ([da701ee](da701ee)), closes [liuweiGL#31](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/31)
* fix the error caused by the path containing spaces ([655bfa4](655bfa4)), closes [liuweiGL#17](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/17)
* fix tsc report an type error ([3695e8c](3695e8c))
* fix wrong debug log ([510d381](510d381))
* generated code include vite code ([e5adc6b](e5adc6b)), closes [liuweiGL#47](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/47)
* get warning from esbuild build ([7e4d968](7e4d968))
* Illegal operation in linux ([d299720](d299720)), closes [liuweiGL#63](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/63)
* local hosts not include ips in node18 ([b710399](b710399))
* local path warning only if path isn't found ([liuweiGL#32](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/32)) ([ac7f533](ac7f533))
* mkcert initialization error ([b8e6e96](b8e6e96)), closes [liuweiGL#62](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/62)
* not working if the mkcert in directory with special charaters ([e3a5b63](e3a5b63)), closes [liuweiGL#61](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/61)
* Plugin‘s type definition is not generic ([1d031d1](1d031d1)), closes [liuweiGL#44](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/44)
* **plugin:** fix linux system permission denied ([bc9c93e](bc9c93e)), closes [liuweiGL#7](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/7)
* **plugin:** mkcert binary lost ([liuweiGL#13](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/13)) ([d4a881b](d4a881b))
* preview mode can use https ([liuweiGL#28](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/28)) ([048a8d1](048a8d1))
* rollback required node version ([782ab10](782ab10))
* **script:** fix read config.json error ([bb227c7](bb227c7))
* **script:** fix release workflow wrong ([d0cf9a3](d0cf9a3))
* **script:** 修复发包之前没有构建资源 ([dbd4b76](dbd4b76))
* **script:** 修复获取最新版本号错误 ([d4ce4c7](d4ce4c7))
* the plugin reports mkcert not recognized as an internal or external command when  parentheses in the folder name ([02278c8](02278c8)), closes [liuweiGL#83](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/83)
* typescript 5.0.2 can not resolve typings ([d070319](d070319)), closes [liuweiGL#65](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/65)
* typescript can't correct resolve .d.ts file ([363d66a](363d66a))
* upgrade dependencies, fix vulnerability ([8c2c0b1](8c2c0b1)), closes [liuweiGL#76](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/76)
* vite version range incorrect ([1486c44](1486c44))
* 修复node14不支持replaceAll导致报错的问题 ([liuweiGL#66](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/66)) ([6936de3](6936de3))

### Features

*  allow force to generate certificate ([ce4c4e0](ce4c4e0))
* add `savePath` `keyFileName`  `certFileName` parameters ([b12de07](b12de07)), closes [liuweiGL#56](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/56)
* add log informations ([1f9c356](1f9c356))
* add logger prefix ([bee34ee](bee34ee))
* always include local hosts ([6bab2ec](6bab2ec))
* complete 1.0 version ([b3773a0](b3773a0))
* complete coding.net mirror setting ([f663270](f663270))
* complete the initial version ([6316831](6316831))
* dev downloader ([9c084e2](9c084e2))
* dev mkcert downloader ([ff9b411](ff9b411))
* export BasetSource-class ([liuweiGL#37](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/37)) ([3f25861](3f25861))
* https is enabled by default ([d1b8197](d1b8197))
* **plugin:** add certificate cache ([e07be64](e07be64))
* **plugin:** plugin only works in serve mode ([d471652](d471652))
* **plugin:** 支持自定义域名 ([liuweiGL#11](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/11)) ([fd6f58e](fd6f58e))
* pretty write config.json file ([0a556ab](0a556ab))
* retain the existing ca ([ee85a33](ee85a33)), closes [liuweiGL#59](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/59)
* rsbuild-plugin-mkcert ([6299325](6299325))
* save CA file to savePath ([6b29fe4](6b29fe4)), closes [liuweiGL#58](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/58)
* support MacOS with M2 chip ([liuweiGL#67](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/67)) ([aebfd07](aebfd07))
* Support more platforms and architectures ([0cb9571](0cb9571)), closes [liuweiGL#68](https://github.com/skymoonya/rsbuild-plugin-mkcert/issues/68)
* support read host from server config ([305639b](305639b))
* Upgrade vite to 5.0 ([ac39d72](ac39d72))
* use peerDependence instead of dependence to control vite version ([542f15e](542f15e))
* 适配 v4.3.0 ([a117ed8](a117ed8))
* 适配 vite3.0 ([960ff59](960ff59))

### Performance Improvements

* pretty log formatter ([f75dfd1](f75dfd1))
* upgrade all dependencies ([fd5a8c0](fd5a8c0))
* upgrade dependencies version ([306f844](306f844))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants