feat(token): ensure auth provides correct response & token has actor #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlowFlorent
commented
Jun 15, 2022
nvie
reviewed
Jun 16, 2022
nvie
approved these changes
Jun 16, 2022
| } | ||
| } | ||
|
|
||
| // TODO: unused in all packages & not accessible from @liveblocks/client users, remove? |
There was a problem hiding this comment.
Ha! Great catch, I think you're right. It's good to also always check usage of these APIs in https://github.com/liveblocks/liveblocks-cloudflare and https://github.com/liveblocks/liveblocks.io, because those might also import these APIs using import { parseAuthToken } from "@liveblocks/client/internal" (I learned this the hard way!), but I just checked them and they're also not using this anymore either!
I think what happened is that at the end of some refactorings, we ended up with only usages of parseRoomAuthToken, and never this one anymore, and I forgot to clean this one up. I think it would indeed be safe to remove this — nice! ✨🧽✨
FlowFlorent
commented
Jun 16, 2022
FlowFlorent
commented
Jun 16, 2022
Co-authored-by: Vincent Driessen <me@nvie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: https://github.com/liveblocks/liveblocks.io/pull/261
Related issue: #331