Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Choose button if draft file is a directory #823

Merged
merged 5 commits into from Dec 24, 2021
Merged

Disable Choose button if draft file is a directory #823

merged 5 commits into from Dec 24, 2021

Conversation

Benjamin-Philip
Copy link
Contributor

Also close #814

@Benjamin-Philip
Copy link
Contributor Author

I've got a working version ready, though we might need to tweak the css a little bit.

@jonatanklosko jonatanklosko mentioned this pull request Dec 24, 2021
Closed
jonatanklosko
jonatanklosko approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonatanklosko jonatanklosko merged commit fc3fad6 into livebook-dev:main Dec 24, 2021
@Benjamin-Philip Benjamin-Philip deleted the bp-do-not-choose-if-dir branch January 27, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanklosko jonatanklosko jonatanklosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When saving livebook, if no name is given, file is saved as ".livemd"
2 participants
@Benjamin-Philip @jonatanklosko