Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Choose button if draft file is a directory #823

Merged
merged 5 commits into from
Dec 24, 2021
Merged

Disable Choose button if draft file is a directory #823

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f7cfc0
Disable Choose button if draft file is a directory
Benjamin-Philip Dec 23, 2021
3147714
Fix warnings
Benjamin-Philip Dec 24, 2021
43a2cbc
Decide if choose is disabled on handle info
Benjamin-Philip Dec 24, 2021
e272920
Revert "Decide if choose is disabled on handle info"
Benjamin-Philip Dec 24, 2021
d4e5b44
Use the disabled attribute
Benjamin-Philip Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 16 additions & 7 deletions lib/livebook_web/live/session_live/persistence_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ defmodule LivebookWeb.SessionLive.PersistenceLive do
attrs: attrs,
new_attrs: attrs,
draft_file: nil,
choose_disabled: nil,
saved_file: nil
)}
end
Expand Down Expand Up @@ -116,11 +117,17 @@ defmodule LivebookWeb.SessionLive.PersistenceLive do
tabindex="-1">
Cancel
</button>
<button class="button-base button-blue"
phx-click="confirm_file"
tabindex="-1">
jonatanklosko marked this conversation as resolved.
Show resolved Hide resolved
Choose
</button>
<%= unless @choose_disabled do %>
<button class="button-base button-blue"
phx-click="confirm_file"
tabindex="-1">
Choose
</button>
<% else %>
<button class="button-base button-blue opacity-50 cursor-not-allowed">
Choose
</button>
<% end %>
</div>
</.live_component>
</div>
Expand Down Expand Up @@ -155,7 +162,8 @@ defmodule LivebookWeb.SessionLive.PersistenceLive do
@impl true
def handle_event("open_file_select", %{}, socket) do
file = socket.assigns.new_attrs.file || Livebook.Config.default_dir()
{:noreply, assign(socket, draft_file: file)}
choose_disabled = FileSystem.File.dir?(file)
{:noreply, assign(socket, draft_file: file, choose_disabled: choose_disabled)}
end

def handle_event("close_file_select", %{}, socket) do
Expand Down Expand Up @@ -218,7 +226,8 @@ defmodule LivebookWeb.SessionLive.PersistenceLive do

@impl true
def handle_info({:set_file, file, _file_info}, socket) do
{:noreply, assign(socket, draft_file: file)}
choose_disabled = FileSystem.File.dir?(file)
{:noreply, assign(socket, draft_file: file, choose_disabled: choose_disabled)}
end

def handle_info(:confirm_file, socket) do
Expand Down