Added Errors component #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale-kacperczyk
force-pushed
the
feature/dps-2201
branch
from
c9b4b3e
to
0eb7015
Compare
jakubsikora
requested changes
Aug 4, 2020
src/components/extensions/Errors.js
Outdated
Comment on lines
7
to
16
| const formattedErrors = allErrors.map((error) => { | ||
| const newError = ERRORS.find((item) => item.id === error); | ||
| return newError; | ||
| }).map((error) => { | ||
| const errorArray = []; | ||
| errorArray.push(<code className="language-text">{error.id}</code>) | ||
| errorArray.push(error.message) | ||
| errorArray.push(error.description) | ||
| return errorArray; | ||
| }) |
There was a problem hiding this comment.
This is good, but let's make it better to avoid double iteration :)
Suggested change
| const formattedErrors = allErrors.map((error) => { | |
| const newError = ERRORS.find((item) => item.id === error); | |
| return newError; | |
| }).map((error) => { | |
| const errorArray = []; | |
| errorArray.push(<code className="language-text">{error.id}</code>) | |
| errorArray.push(error.message) | |
| errorArray.push(error.description) | |
| return errorArray; | |
| }) | |
| const formattedErrors = allErrors.map((error) => { | |
| const newError = ERRORS.find((item) => item.id === error); | |
| return [ | |
| <code className="language-text">{newError.id}</code>, | |
| newError.message, | |
| newError.description | |
| ]; | |
| }) |
| `; | ||
|
|
||
| const Scopes = ({ title, scopes }) => { | ||
| const Scopes = ({ scopes }) => { | ||
| const allScopes = scopes.split(","); | ||
| const formattedScopes = allScopes.map((scope) => { |
| import React from "react"; | ||
| import PropTypes from "prop-types"; | ||
| import styled from "@emotion/styled"; | ||
| import { v4 as uuidv4 } from 'uuid'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Links
📓 Description
Created a new component -
Errors. It mirrors theScopescomponent.👷 Type of change (remove not needed)
Features (for the website)