This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[Bug 20666]] Property Inspector / Geometry: Remove All button #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot work The first change adds a parameter to the setValue call (where the button click is handled) to remove all geometries and expands that handler to match (depends on an earlier PR that is merged already). The second change is to add a command to clear geometry keys that are not needed. If no geometry sides are set, then the other associated settings are removed. This new command is called from the revIDESetGeometry handler. The third change is to add checks to prevent the revCalculateGeometryDistances from calculating distances for sides that are not needed.
|
@livecode-vulcan review ok 12c321c |
|
💙 review by @montegoulding ok 12c321c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Remove All" button on the Geometry tab of the Property Inspector currently has no effect.
The first change adds a parameter to the setValue call (where the button click is handled) to remove all geometries and expands that handler to match (depends on an earlier PR that is merged already).
The second change is to add a command to clear geometry keys that are not needed. If no geometry sides are set, then the other associated settings are removed. This new command is called from the revIDESetGeometry handler.
The third change is to add checks to prevent the revCalculateGeometryDistances from calculating distances for sides that are not needed.