This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Fix formattedheight to return a realistic value #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this makes the caret look too low in comparison to the caret position in modern UIs.
Not accounting for this meant that the height of text was being calculated incorrectly.
With the new text metrics, the formattedHeight value bore only a passing relationship with reality. By tweaking the calculation slightly (and, as a side-effect, better matching how heights for field scrollbars are calculated), the formattedHeight now returns a value that works for auto-sizing fields to match the height of their contents.
|
@livecode-vulcan review ok 70d21c1 |
livecode-vulcan
added a commit
that referenced
this pull request
Feb 16, 2016
Fix formattedheight to return a realistic value Contains 3 fixes that allows livecode/livecode-ide#851 to work properly: 1. Don't draw carets so low they descend outside the formattedheight 2. Correct the metrics used for Windows fonts 3. Fix the "magic" factor used when calculating formattedHeight for fields
livecodefraser
added a commit
that referenced
this pull request
Feb 16, 2016
Fix formattedheight to return a realistic value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains 3 fixes that allows livecode/livecode-ide#851 to work properly: