[[ WindowsPlayer ]] Update the player object on Windows to use DirectShow #4022
Conversation
… from player rect and vice versa.
…Bitmap and bool return value to indicate success. [[ WindowsPlayer ]] Modify MCPlayer::draw() to pass required image size when locking bitmap for offscreen rendering.
…m-internal.h [[ WindowsPlayer ]] Rename mac-player.mm to platform-player.cpp and remove mac-specific includes.
… to build configuration files.
…ise exclusions to allow Win32 builds to include required MCPlatform sources
…atures, and enable platform player feature on win32
…eturning an MCWin32DSPlayer ref
…ileName properties
[[ WIndowsPlayer ]] Add video window proc to reconfigure video window on resize. [[ WindowsPlayer ]] Fix video window class not registered
…+reattach native view. [[ WindowsPlayer ]] Fix infinite loop when MCPlayer::playstop() returns false due to being uninitialised
…g view shown / hidden [[ WindowsPlayer ]] Add property accessor stubs
…rary dependency to libfoundation.gyp
…Yet Another AutoRelease Class)
…ing / setting volume
|
Reviewed 1 of 22 files at r2, 2 of 3 files at r4. docs/dictionary/property/callbacks.lcdoc, line 13 [r3] (raw file):
|
|
Reviewed 6 of 7 files at r5. Comments from Reviewable |
|
Review status: 54 of 55 files reviewed at latest revision, 4 unresolved discussions. docs/dictionary/property/callbacks.lcdoc, line 13 [r3] (raw file):
|
…will overflow uint32_t
|
Review status: 54 of 55 files reviewed at latest revision, 5 unresolved discussions. engine/src/w32-ds-player.cpp, line 605 [r3] (raw file):
|
|
Review status: 54 of 55 files reviewed at latest revision, 5 unresolved discussions. engine/src/sysdefs.h, line 53 [r3] (raw file):
|
|
Review status: 54 of 55 files reviewed at latest revision, 4 unresolved discussions. engine/src/platform.h, line 1026 [r3] (raw file):
|
|
I have now added Changes: sections to the affected docs and updated Copyright notices where appropriate.
|
|
Review status: 54 of 55 files reviewed at latest revision, 2 unresolved discussions. engine/src/w32-ds-player.cpp, line 618 [r3] (raw file):
|
|
@livecodeian Thanks for addressing all those points! I think that all that's needed now is a nice comprehensive release note and this is ready to go!
|
|
Release note added.
|
|
@livecode-vulcan review ok 37f1c3a |
…edia [[ WindowsPlayer ]] Update the player object on Windows to use DirectShow Modified MCPlatformPlayer to return the native view, using MCNativeLayer to manage geometry / visibility changes. Implemented new MCPlatformPlayer based on DirectShow - switched Windows engine to use MCPlayer based on MCPlatformPlayer. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/livecode/livecode/4022) <!-- Reviewable:end -->
|
@livecodeian Oops, I wish you'd told me you'd pushed these additional changes! We could have got them merged in today! 😞 @livecode-vulcan review ok 7a33cff |
…edia [[ WindowsPlayer ]] Update the player object on Windows to use DirectShow Modified MCPlatformPlayer to return the native view, using MCNativeLayer to manage geometry / visibility changes. Implemented new MCPlatformPlayer based on DirectShow - switched Windows engine to use MCPlayer based on MCPlatformPlayer. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/livecode/livecode/4022) <!-- Reviewable:end -->
Modified MCPlatformPlayer to return the native view, using MCNativeLayer to manage geometry / visibility changes.
Implemented new MCPlatformPlayer based on DirectShow - switched Windows engine to use MCPlayer based on MCPlatformPlayer.
This change is