This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 19580 ]] Ensure colors round-trip correctly through styledText #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livecodeali
force-pushed
the
bugfix-19580
branch
from
05ba56f
to
e75c82d
Compare
|
@livecode-vulcan review ok e75c82d |
|
💙 review by @runrevmark ok e75c82d |
livecode-vulcan
added a commit
that referenced
this pull request
Jan 24, 2018
[[ Bug 19580 ]] Ensure colors round-trip correctly through styledText
|
😎 test success e75c82d
|
|
Just realised this should have a test! |
|
@runrevmark Just added a test, could you re-review please? |
|
Hmm, actually this is still failing on linux... Maybe there is a further problem there |
livecodeali
force-pushed
the
bugfix-19580
branch
from
61a686e
to
ed65f30
Compare
|
@livecode-vulcan review ok ed65f30 |
|
💙 review by @montegoulding ok ed65f30 |
livecode-vulcan
added a commit
that referenced
this pull request
Feb 6, 2018
[[ Bug 19580 ]] Ensure colors round-trip correctly through styledText
|
😞 test failure ed65f30
|
|
@livecode-vulcan retry ed65f30 |
livecode-vulcan
added a commit
that referenced
this pull request
Feb 6, 2018
[[ Bug 19580 ]] Ensure colors round-trip correctly through styledText
|
😎 test success ed65f30
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.