This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Emscripten ]] Native HTML5 Button Widget #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule Update LiveCodeDC and LiveCodeLibURL to use object ref functions
Added MCJSObjectRef value type. Implemented conversion between JS & MCValueRef types. Added argument passing to JS eval function, allowing easier scripting.
Allows calling LCB handlers from JavaScript
MCPointIsEqual - compare two points for equality MCPointOffset - return the given point shifted by the x, y offset
livecodeali
reviewed
Feb 21, 2018
|
|
||
| return true; | ||
| } | ||
|
|
||
| MCScreenDC::MCScreenDC() | ||
| : m_main_window(nil), m_mouse_button_state(0) | ||
| { | ||
| m_mouse_position = MCPointMake(-1,-1); |
There was a problem hiding this comment.
Would : m_main_window(nil), m_mouse_button_state(0), m_mouse_position({-1, -1}) work here? Just curious as it would be slightly more efficient (not that this class is constructed very often :-D)
There was a problem hiding this comment.
Something like m_mouse_position{-1, -1} should work I think.
|
@livecode-vulcan review ok 3645b56 |
|
💙 review by @livecodeali ok 3645b56 |
livecode-vulcan
added a commit
that referenced
this pull request
Feb 27, 2018
…tton [[ Emscripten ]] Native HTML5 Button Widget This PR implements a LCB widget containing a native HTML button element. In addition, enhancements have been made to the bridging of values between JavaScript and LCB. It is now possible to pass JavaScript objects as MCJSObjectRef values, which can be used as parameter values when calling javascript code from LCB. DEPENDS ON PR: livecode/livecode-ide#1902
|
😎 test success 3645b56
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a LCB widget containing a native HTML button element.
In addition, enhancements have been made to the bridging of values between JavaScript and LCB. It is now possible to pass JavaScript objects as MCJSObjectRef values, which can be used as parameter values when calling javascript code from LCB.
DEPENDS ON PR: livecode/livecode-ide#1902