This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 220
[[ Bug 21019 ]] Implement mobileSetFullScreenRectForOrientations #6427
Merged
livecodepanos
merged 4 commits into
livecode:develop-8.1
from
montegoulding:bugfix-21019
Apr 11, 2018
Merged
[[ Bug 21019 ]] Implement mobileSetFullScreenRectForOrientations #6427
livecodepanos
merged 4 commits into
livecode:develop-8.1
from
montegoulding:bugfix-21019
Apr 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements a new mobile command to set the fullscreen rect for a given list of comma separated orientations. This allows a fullscreen stack to chance its rect automatically when the orientation changes and handle the resizeStack message to layout controls for the new width and height.
This patch changes android to cache display info and update it when the bitmap is being reconfigured. Previously it was possible for many calls to get the work area from the OS and for it to change at unexpected times.
@livecode-vulcan review ok 76347d1 |
💙 review by @livecodeali ok 76347d1 |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 11, 2018
[[ Bug 21019 ]] Implement mobileSetFullScreenRectForOrientations This patch implements a new mobile command to set the fullscreen rect for a given list of comma separated orientations. This allows a fullscreen stack to chance its rect automatically when the orientation changes and handle the resizeStack message to layout controls for the new width and height.
😎 test success 76347d1
|
Type: command | ||
|
||
Syntax: mobileSetAllowedOrientations <orientations>[, <rect>] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be mobileSetFullScreenRectForOrientations <orientations>[, <rect>
]
I guess this is the reason whey searching for mobileSetF
shows nothing in the dictionary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok will fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a new mobile command to set the fullscreen rect
for a given list of comma separated orientations. This allows a fullscreen
stack to chance its rect automatically when the orientation changes and
handle the resizeStack message to layout controls for the new width and height.