Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 21019 ]] Implement mobileSetFullScreenRectForOrientations #6427

Merged
merged 4 commits into from
Apr 11, 2018

Conversation

montegoulding
Copy link
Member

This patch implements a new mobile command to set the fullscreen rect
for a given list of comma separated orientations. This allows a fullscreen
stack to chance its rect automatically when the orientation changes and
handle the resizeStack message to layout controls for the new width and height.

This patch implements a new mobile command to set the fullscreen rect
for a given list of comma separated orientations. This allows a fullscreen
stack to chance its rect automatically when the orientation changes and
handle the resizeStack message to layout controls for the new width and height.
This patch changes android to cache display info and update it when
the bitmap is being reconfigured. Previously it was possible for many
calls to get the work area from the OS and for it to change at unexpected
times.
@livecodeali
Copy link
Member

@livecode-vulcan review ok 76347d1

@livecode-vulcan
Copy link
Contributor

💙 review by @livecodeali ok 76347d1

livecode-vulcan added a commit that referenced this pull request Apr 11, 2018
[[ Bug 21019 ]] Implement mobileSetFullScreenRectForOrientations

This patch implements a new mobile command to set the fullscreen rect
for a given list of comma separated orientations. This allows a fullscreen
stack to chance its rect automatically when the orientation changes and
handle the resizeStack message to layout controls for the new width and height.
@livecode-vulcan
Copy link
Contributor

😎 test success 76347d1

  • try-community-armv6-android-api8: success
  • try-community-armv6-android-api9: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.3: success
  • try-community-universal-ios-iphonesimulator11.3: success
  • try-community-universal-mac-macosx10.6: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian7: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian7: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit 1b9e41f into livecode:develop-8.1 Apr 11, 2018
Type: command

Syntax: mobileSetAllowedOrientations <orientations>[, <rect>]

Copy link
Contributor

@livecodepanos livecodepanos Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be mobileSetFullScreenRectForOrientations <orientations>[, <rect>]

I guess this is the reason whey searching for mobileSetF shows nothing in the dictionary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok will fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants