Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ LCB ]] [[ Docs ]] Add OS and Platforms to LCB Metadata #6623

Merged
merged 2 commits into from
Aug 23, 2018

Conversation

bwmilby
Copy link
Contributor

@bwmilby bwmilby commented Aug 3, 2018

Added new metadata keys to generate.g file (os and platforms)

Added revSBNormalizePlatforms to revSBLibrary. This new handler will
take a list of OSs in the dictionary format and convert them to the
standard names that are used by the SB. If no OSs are specified, then the
list of Platforms will be used. As a fall back, if the list remains
empty (due to invalid data in the OS or Platforms lists), then it will
revert to the previous behavior and supply a list of all platforms.

Add metadata case block to the revDocsExtractDocBlocks handler of
revDocsParser. This block will add the metadata keys to the library
comment block so that they get included in the dictionary. The initial
list of keys is author, os, platforms, version but only OS and
Platforms are in the actual dictionary (the other 2 are in the generated
lcdoc files).

Updated Element lists for revDocsParseDocText to inherit os and
platforms from Library. Updated Library elements to add os,
platforms, and associations. Added case statements for os and
platforms and removed trailing white space in the area.

Updated extensionFetchMetadata in extension-utils to parse the
platforms and os keys that were added.

Added new metadata keys to LiveCode Builder Language Reference

Spelling correction in LiveCode Builder Style Guide

Add metadata OS key to LCB files:

  • androidaudiorecorder
  • androidbgaudio
  • toast
  • android-utils
  • androidbutton
  • androidfield
  • html5button
  • iosbutton
  • macbutton
  • mactextfield

Requires livecode/livecode-ide#1988 for full functionality.

Initial discussion here: http://forums.livecode.com/viewtopic.php?f=93&t=31255

Added new metadata keys to *LiveCode Builder Language Reference*

Spelling correction in *LiveCode Builder Style Guide*

Add metadata OS key to LCB files:
- androidaudiorecorder
- androidbgaudio
- toast
- android-utils
- androidbutton
- androidfield
- html5button
- iosbutton
- macbutton
- mactextfield
Added new metadata keys to `generate.g` file

Added `revSBNormalizePlatforms` to `revSBLibrary`. This new handler will
take a list of OSs in the dictionary format and convert them to the
standard names that used by the SB. If no OSs are specified, then the
list of Platforms will be used. As a fall back, if the list remains
empty (due to invalid data in the OS or Platforms lists), then it will
revert to the previous behavior and supply a list of all platforms.

Add `metadata` to the `revDocsExtractDocBlocks` handler of
`revDocsParser`. This block will add the metadata keys to the library
comment block so that they get included in the dictionary. The initial
list of keys is `author, os, platforms, version` but only OS and
Platforms are in the actual dictionary (the other 2 are in the generated
lcdoc files).

Updated Element lists for `revDocsParseDocText` to inherit `os` and
`platforms` from Library.  Updated Library elements to add `os`,
`platforms`, and `associations`.  Added case statements for `os` and
`platforms` and removed trailing white space in the area.

Updated `extensionFetchMetadata` in `extension-utils` to parse the
platforms and os keys that were added.
@bwmilby bwmilby changed the title [[Feature]] Add OS and Platforms to LCB Metadata [[ LCB ]] [[ Docs ]] Add OS and Platforms to LCB Metadata Aug 4, 2018
@montegoulding
Copy link
Member

@livecode-vulcan review ok 0c18c26

Thanks again @bwmilby !

@livecode-vulcan
Copy link
Contributor

💙 review by @montegoulding ok 0c18c26

livecode-vulcan added a commit that referenced this pull request Aug 21, 2018
 [[ LCB ]] [[ Docs ]] Add OS and Platforms to LCB Metadata

Added new metadata keys to `generate.g` file (os and platforms)

Added `revSBNormalizePlatforms` to `revSBLibrary`. This new handler will
take a list of OSs in the dictionary format and convert them to the
standard names that are used by the SB. If no OSs are specified, then the
list of Platforms will be used. As a fall back, if the list remains
empty (due to invalid data in the OS or Platforms lists), then it will
revert to the previous behavior and supply a list of all platforms.

Add `metadata` case block to the `revDocsExtractDocBlocks` handler of
`revDocsParser`. This block will add the metadata keys to the library
comment block so that they get included in the dictionary. The initial
list of keys is `author, os, platforms, version` but only OS and
Platforms are in the actual dictionary (the other 2 are in the generated
lcdoc files).

Updated Element lists for `revDocsParseDocText` to inherit `os` and
`platforms` from Library.  Updated Library elements to add `os`,
`platforms`, and `associations`.  Added case statements for `os` and
`platforms` and removed trailing white space in the area.

Updated `extensionFetchMetadata` in `extension-utils` to parse the
platforms and os keys that were added.

Added new metadata keys to *LiveCode Builder Language Reference*

Spelling correction in *LiveCode Builder Style Guide*

Add metadata OS key to LCB files:
- androidaudiorecorder
- androidbgaudio
- toast
- android-utils
- androidbutton
- androidfield
- html5button
- iosbutton
- macbutton
- mactextfield

Requires livecode/livecode-ide#1988 for full functionality.

Initial discussion here:  http://forums.livecode.com/viewtopic.php?f=93&t=31255
@livecode-vulcan
Copy link
Contributor

😎 test success 0c18c26

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.4: success
  • try-community-universal-ios-iphonesimulator11.4: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos added this to the 9.1.0-dp-1 milestone Aug 23, 2018
@livecodepanos livecodepanos merged commit db32c3a into livecode:develop Aug 23, 2018
@bwmilby bwmilby deleted the bwm-lcb-manifest branch April 27, 2019 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants