Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[21669] Ensure an error is thrown when Map API key is empty #6777

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

livecodepanos
Copy link
Contributor

@livecodepanos livecodepanos commented Nov 5, 2018

This patch ensures an appropriate error is thrown - in this case:

Missing standalone settings for com.livecode.widget.native.map:
	Google Maps V2 API key
Please set on standalone inclusions pane

@livecodepanos livecodepanos added this to the 9.0.2-rc-1 milestone Nov 5, 2018
@livecodeali
Copy link
Member

@livecode-vulcan review ok 0595b00

@livecode-vulcan
Copy link
Contributor

💙 review by @livecodeali ok 0595b00

livecode-vulcan added a commit that referenced this pull request Nov 5, 2018
[21669] Ensure an error is thrown when Map API key is empty

This patch ensures an appropriate error is thrown - in this case:
```
Missing standalone settings for com.livecode.widget.native.map:
	Google Maps V2 API key
Please set on standalone inclusions pane
```
@livecode-vulcan
Copy link
Contributor

😎 test success 0595b00

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.0: success
  • try-community-universal-ios-iphonesimulator12.0: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit e304331 into livecode:develop-9.0 Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants