This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[19277] Ensure the effective rect is fetched correctly when screen is locked #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livecodepanos
changed the title
runrevmark
reviewed
Dec 5, 2018
engine/src/desktop-stack.cpp
Outdated
| { | ||
| MCRectangle t_content_rect, t_diff_rect; | ||
| MCscreen->platform_getwindowgeometry(window, t_content_rect); | ||
| t_diff_rect = MCU_subtract_rect(t_content_rect, t_frame_rect); |
There was a problem hiding this comment.
I don't think MCU_subtract_rect is correc there - t_content_rect here is the window's current rect, and t_frame_rect is the window's current effective rect. The frame rect will contain the content rect, which gives you four margins - one for top, left, right and bottom. You then want to apply these margins to the rect of the stack - e.g. left of effective rect = rect.left + (t_content_rect.x - t_frame_rect.x).
|
@livecodepanos this looks testable when running in ui mode to me so I'll add the needs tests label |
|
@livecode-vulcan review ok e90667f |
|
💙 review by @montegoulding ok e90667f |
livecode-vulcan
added a commit
that referenced
this pull request
Dec 16, 2018
[19277] Ensure the effective rect is fetched correctly when screen is locked
|
😞 test failure e90667f
|
|
@livecode-vulcan review ok 0011c72 |
|
💙 review by @montegoulding ok 0011c72 |
livecode-vulcan
added a commit
that referenced
this pull request
Dec 17, 2018
[19277] Ensure the effective rect is fetched correctly when screen is locked
|
😎 test success 0011c72
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.