This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 17323 ]] refresh windows after backdrop is created #7066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the call to `MCstacks->refresh()` to after the creation of the presentation of the backdrop window to ensure that stack windows are raised above it.
|
Thanks, Panos. |
|
@livecode-vulcan review ok ebed1af |
|
💙 review by @montegoulding ok ebed1af |
livecode-vulcan
added a commit
that referenced
this pull request
May 29, 2019
[[ Bug 17323 ]] refresh windows after backdrop is created This patch moves the call to `MCstacks->refresh()` to after the creation of the presentation of the backdrop window to ensure that stack windows are raised above it. Notes: 1. Submitting this PR on behalf of @mwieder 2. This PR replaces #6496 3. No bugfix note included, as there is already a file `docs/notes/bugfix-17323.md` from a previous PR that worked partially (i.e. fixed the problem in some Linux distros)
|
😞 test failure ebed1af
|
|
It's not at all clear to me why there's a vulcan build failure for this on the 64-bit windows platform. |
|
@livecode-vulcan retry ebed1af @mwieder the logs indicate a quite unrelated failure but not much info about it so I'm retrying to see if vulcan magically sorts itself out ;-) |
livecode-vulcan
added a commit
that referenced
this pull request
May 30, 2019
[[ Bug 17323 ]] refresh windows after backdrop is created This patch moves the call to `MCstacks->refresh()` to after the creation of the presentation of the backdrop window to ensure that stack windows are raised above it. Notes: 1. Submitting this PR on behalf of @mwieder 2. This PR replaces #6496 3. No bugfix note included, as there is already a file `docs/notes/bugfix-17323.md` from a previous PR that worked partially (i.e. fixed the problem in some Linux distros)
|
😎 test success ebed1af
|
|
Yay! Three cheers for things that magically fix themselves! I'm putting on my tinfoil helmet now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the call to
MCstacks->refresh()to after the creation of thepresentation of the backdrop window to ensure that stack windows are raised
above it.
Notes:
docs/notes/bugfix-17323.mdfrom a previous PR that worked partially (i.e. fixed the problem in some Linux distros)