This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22927 ]] Fix tracking of mouse events during modal session #7445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the tracking of mouse events in modal sessions on MacOS X by updating the last mouse event in the mouseDown and mouseDragged methods of the window, rather than by searching through the event queue.
This patch adds a release note for bug 22927, where drag n' drop would not work within a modal stack
runrevmark
approved these changes
Oct 12, 2020
|
@livecode-vulcan review ok 76c96d5 |
|
💙 review by @runrevmark ok 76c96d5 |
livecode-vulcan
added a commit
that referenced
this pull request
Oct 12, 2020
[[ Bug 22927 ]] Fix tracking of mouse events during modal session This patch fixes the tracking of mouse events in modal sessions on MacOS X by updating the last mouse event in the mouseDown and mouseDragged methods of the window, rather than by searching through the event queue. Fixes https://quality.livecode.com/show_bug.cgi?id=22927
livecode-vulcan
added a commit
that referenced
this pull request
Oct 12, 2020
[[ Bug 22927 ]] Fix tracking of mouse events during modal session This patch fixes the tracking of mouse events in modal sessions on MacOS X by updating the last mouse event in the mouseDown and mouseDragged methods of the window, rather than by searching through the event queue. Fixes https://quality.livecode.com/show_bug.cgi?id=22927
|
😞 test failure 76c96d5
|
|
@livecode-vulcan retry 76c96d5 |
livecode-vulcan
added a commit
that referenced
this pull request
Oct 12, 2020
[[ Bug 22927 ]] Fix tracking of mouse events during modal session This patch fixes the tracking of mouse events in modal sessions on MacOS X by updating the last mouse event in the mouseDown and mouseDragged methods of the window, rather than by searching through the event queue. Fixes https://quality.livecode.com/show_bug.cgi?id=22927
|
The previous checks on Mac and iOS13.5 failed because build-mac-4 with Xcode12 was used. I have disabled build-mac-4 and enabled build-mac-3 (that has Xcode 9.4.1) so this PR should pass now. |
|
😎 test success 76c96d5
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the tracking of mouse events in modal sessions on
MacOS X by updating the last mouse event in the mouseDown and
mouseDragged methods of the window, rather than by searching through
the event queue.
Fixes https://quality.livecode.com/show_bug.cgi?id=22927