Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 22896 ]] Fix click location for sheet dialogs on MacOS Big Sur #7474

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

livecodeian
Copy link
Contributor

This patch fixes issue 22896, where the buttons on an answer dialog opened as sheet would not respond to mouse clicks on MacOS Big Sur

Fixes https://quality.livecode.com/show_bug.cgi?id=22896

This patch fixes an issue on MacOS Big Sur where setting the rect of an
answer dialog opened as sheet would fail, leaving the content rect in an
inconsistent state, leading to an incorrect offset added to the mouse
location.
This was preventing the dialog buttons from responding to mouse clicks.
This patch adds a release note for issue 22896, where the buttons on an
answer dialog opened as sheet would not respond to mouse clicks on
MacOS Big Sur
@livecodeian livecodeian added this to the 9.6.2-rc-1 milestone Nov 12, 2020
@livecodeian livecodeian self-assigned this Nov 12, 2020
@runrevmark
Copy link
Contributor

@livecode-vulcan review ok 7a52b94

@livecode-vulcan
Copy link
Contributor

💙 review by @runrevmark ok 7a52b94

livecode-vulcan added a commit that referenced this pull request Nov 13, 2020
[[ Bug 22896 ]] Fix click location for sheet dialogs on MacOS Big Sur

This patch fixes issue 22896, where the buttons on an answer dialog opened as sheet would not respond to mouse clicks on MacOS Big Sur

Fixes https://quality.livecode.com/show_bug.cgi?id=22896
@livecode-vulcan
Copy link
Contributor

😎 test success 7a52b94

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: success
  • try-community-arm64-android-ndk16r15: success
  • try-community-x86-android-ndk16r15: success
  • try-community-x86_64-android-ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos14.1: success
  • try-community-universal-ios-iphoneos13.5: success
  • try-community-universal-ios-iphonesimulator14.1: success
  • try-community-universal-ios-iphonesimulator13.5: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit c780dc8 into livecode:develop-9.6 Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants