Make initial launch clearing safer #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisers
reviewed
Oct 8, 2018
| @@ -95,12 +94,6 @@ private Bundle readFromDisk(@NonNull String uuid) { | |||
|
|
|||
| @SuppressLint("NewApi") | |||
| private void registerForLifecycleEvents(@NonNull Context context) { | |||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.ICE_CREAM_SANDWICH) { | |||
There was a problem hiding this comment.
The version bump probably makes sense anyway, so 👍
|
Thanks @weisers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic used to decide when to clear all saved data on a "fresh" launch to address issues discussed in #22. The existing logic assumed that
Bridge.saveInstanceState/Bridge.restoreInstanceStatewould be used on all Activities in an app by placing those calls in a base class. A failure to do so could result in data being cleared at the wrong time. Since that is neither discussed in the README nor technically enforceable anyway, I've decided to remove that assumption.The updates made here take advantage of the
ActivityLifecycleCallbacksalready being used to hook intoActivity.onCreateevents. I've simply shifted the existing logic fromrestoreInstanceStateto theonActivityCreatedcallback of theActivityLifecycleCallbacks. In order for this to work in all cases, however, I've needed to bump the min SDK from 12 to 14 to ensure that all users ofBridgeget the same behavior. I highly doubt anyone was using this for < 14 so I don't see this as much of a problem.