Unpublish based on track.sender (#325)

* unpublish based on published mediastreamtrack id

* changeset

* Revert "unpublish based on published mediastreamtrack id"

This reverts commit 423fb62.

* remove track based on track.sender

* dont set sender to undefined on stop

* update changeset

.changeset/warm-timers-tan.md

@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+unpublish track based on published track.sender

src/room/participant/LocalParticipant.ts

@@ -686,8 +686,6 @@ export default class LocalParticipant extends Participant {
     }
 
     track = publication.track;
-
-    track.sender = undefined;
     track.off(TrackEvent.Muted, this.onTrackMuted);
     track.off(TrackEvent.Unmuted, this.onTrackUnmuted);
     track.off(TrackEvent.Ended, this.handleTrackEnded);
@@ -701,22 +699,21 @@ export default class LocalParticipant extends Participant {
       track.stop();
     }
 
-    const { mediaStreamTrack } = track;
-
-    if (this.engine.publisher && this.engine.publisher.pc.connectionState !== 'closed') {
-      const senders = this.engine.publisher.pc.getSenders();
-      senders.forEach((sender) => {
-        if (sender.track === mediaStreamTrack) {
-          try {
-            this.engine.publisher?.pc.removeTrack(sender);
-            this.engine.negotiate();
-          } catch (e) {
-            log.warn('failed to remove track', { error: e, method: 'unpublishTrack' });
-          }
-        }
-      });
+    if (
+      this.engine.publisher &&
+      this.engine.publisher.pc.connectionState !== 'closed' &&
+      track.sender
+    ) {
+      try {
+        this.engine.publisher.pc.removeTrack(track.sender);
+        this.engine.negotiate();
+      } catch (e) {
+        log.warn('failed to remove track', { error: e, method: 'unpublishTrack' });
+      }
     }
 
+    track.sender = undefined;
+
     // remove from our maps
     this.tracks.delete(publication.trackSid);
     switch (publication.kind) {

src/room/track/LocalVideoTrack.ts

@@ -75,7 +75,6 @@ export default class LocalVideoTrack extends LocalTrack {
   }
 
   stop() {
-    this.sender = undefined;
     this._mediaStreamTrack.getConstraints();
     this.simulcastCodecs.forEach((trackInfo) => {
       trackInfo.mediaStreamTrack.stop();