Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quality issues with SVC screenshares. #1077

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Fix quality issues with SVC screenshares. #1077

merged 4 commits into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. Fix quality issues with SVC screenshares. 

    When we munged SDP to set bitrate, it was set on the codec's fmtp line.
The codec and its fmtp is shared across media tracks. So if a user is sharing
a camera and screenshare tracks, both tracks will be published at the
same bitrate (typically the user's camera track). This leads to blurry
screenshares.

Additionally, screenshares cannot be encoded in VP9 with L3T3_KEY. Chrome
degrades quality aggressively whenever L1T3 isn't used.
    @davidzhao
    davidzhao committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cc189d6 View commit details
    Browse the repository at this point in the history

  2. fix screenshare button

    @davidzhao
    davidzhao committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    77d30db View commit details
    Browse the repository at this point in the history

  3. changeset

    @davidzhao
    davidzhao committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    7a3d2bd View commit details
    Browse the repository at this point in the history

  4. a couple of fixups

    @davidzhao
    davidzhao committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    da7e6ee View commit details
    Browse the repository at this point in the history