Allow simulcast together with E2EE for supported Safari versions #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba63212 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…nt-sdk-js into lukas/disable-simulcast-iOS
lukasIO
changed the title
…nt-sdk-js into lukas/disable-simulcast-iOS
lukasIO
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1113
Chrome on iOS got reported as
Chromeby our browser parser even though it runs WebKit under the hood. So we failed to detect that we actually have to disable simulcast for Chrome on iOS.Additionally to catching iOS browser in general, it makes sense to re-evaluate whether the restriction (simulcast + E2EE) is still not working in recent Safari versions.
For iOS it will be tricky to differentiate that based on browser version though as we'll need to get insight on the actual Safari version rather than the Firefox/Chrome version.
edit:
found the related webkit bug https://bugs.webkit.org/show_bug.cgi?id=257803.
The fix got released as part of Safari v17.2, so everything beyond that should be fine.
Added iOS version parsing in order to determine the underlying Safari version on chrome and firefox iOS.