Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leave req full reconnect simulation scenario #1137

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented May 13, 2024

No description provided.

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: c302101

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 13, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 79.79 KB (+0.06% 🔺)
dist/livekit-client.umd.js 85.45 KB (+0.06% 🔺)

@lukasIO lukasIO requested a review from boks1971 May 13, 2024 11:38
@@ -172,6 +172,7 @@ <h2>Livekit Sample App</h2>
<option value="force-tls">Force TURN/TLS</option>
<option value="subscribe-all">Subscribe all</option>
<option value="unsubscribe-all">Unsubscribe all</option>
<option value="leave-full-reconnect">Leave Request Full Reconnect</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work with a locally running server I think. Have not check what region settings returns when running server locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll indicate that this is a cloud only thing. But I guess that's ok as migration scenario also doesn't actually migrate on OSS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right.

I think it will not work even if running cloud locally as we have all simulated regions and I am not sure if regions settings things works correctly. Not a big deal. Just a note. I will have a look later if this works in sample app and may be fix it if possible when running cloud locally too.

@lukasIO lukasIO merged commit f6e9d6a into main May 13, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/protocol-update branch May 13, 2024 12:55
@github-actions github-actions bot mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants