-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leave req full reconnect simulation scenario #1137
Conversation
🦋 Changeset detectedLatest commit: c302101 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@@ -172,6 +172,7 @@ <h2>Livekit Sample App</h2> | |||
<option value="force-tls">Force TURN/TLS</option> | |||
<option value="subscribe-all">Subscribe all</option> | |||
<option value="unsubscribe-all">Unsubscribe all</option> | |||
<option value="leave-full-reconnect">Leave Request Full Reconnect</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work with a locally running server I think. Have not check what region settings returns when running server locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll indicate that this is a cloud only thing. But I guess that's ok as migration
scenario also doesn't actually migrate on OSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's right.
I think it will not work even if running cloud locally as we have all simulated regions and I am not sure if regions settings things works correctly. Not a big deal. Just a note. I will have a look later if this works in sample app and may be fix it if possible when running cloud locally too.
No description provided.