Add degradationPreference option for LocalVideoTrack #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80a29f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
requested review from
davidzhao and
cnderrauber
and removed request for
davidzhao
size-limit report 📦
|
cnderrauber
reviewed
May 14, 2024
| @@ -857,6 +858,11 @@ export default class LocalParticipant extends Participant { | |||
|
|
|||
| track.sender = await this.engine.createSender(track, opts, encodings); | |||
|
|
|||
| if (track instanceof LocalVideoTrack && opts.degradationPreference) { | |||
There was a problem hiding this comment.
do we need to check opts.degradationPreference here? or just if (track instanceof LocalVIdeoTrack)
There was a problem hiding this comment.
thanks, this is a leftover, you're right, we should get rid of the second check
…-sdk-js into lukas/maintain-resolution
cnderrauber
approved these changes
May 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localVideoTrack.setDegradationPreferencedegradationPreferencetoTrackPublishOptionsdegradationPreferenceif none is set explicitly