send previous server offer when reconnecting #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdee8e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cnderrauber
commented
Sep 9, 2022
| @@ -1,8 +1,8 @@ | |||
| /* eslint-disable */ | |||
| import Long from 'long'; | |||
There was a problem hiding this comment.
changed by protoc version? have already run yarn install, but still change these file
There was a problem hiding this comment.
strange, this looks like prettier changes. can you run yarn format to see if that helps?
There was a problem hiding this comment.
@lukasIO No change after yarn format ..
lukasIO
approved these changes
Sep 9, 2022
davidzhao
reviewed
Sep 9, 2022
src/room/Room.ts
Outdated
| }), | ||
| offer: | ||
| previousOffer !== null |
There was a problem hiding this comment.
default value is undefined, which is diff from null. using "trueness" operator would be fine in this case.
Suggested change
| previousOffer !== null | |
| previousOffer ? toProtoSessionDescription |
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Oct 4, 2022
* send previous server offer when reconnecting * prettier * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.